tillrohrmann commented on a change in pull request #11320: [FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager at the worker granularity. URL: https://github.com/apache/flink/pull/11320#discussion_r403030485
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ActiveResourceManagerFactory.java ########## @@ -81,4 +83,14 @@ private static Configuration createActiveResourceManagerConfiguration(Configurat ClusterInformation clusterInformation, @Nullable String webInterfaceUrl, ResourceManagerMetricGroup resourceManagerMetricGroup) throws Exception; + + protected WorkerResourceSpec createDefaultWorkerResourceSpec(Configuration configuration) { + final TaskExecutorProcessSpec taskExecutorProcessSpec = TaskExecutorProcessUtils + .newProcessSpecBuilder(configuration) + .withCpuCores(getDefaultCpus(configuration)) + .build(); + return WorkerResourceSpec.fromTaskExecutorProcessSpec(taskExecutorProcessSpec); + } + + protected abstract CPUResource getDefaultCpus(Configuration configuration); Review comment: The same applies to this method. I'm not entirely sure whether this class is the right place for this method. The `ActiveResourceManagerFactory` should not need to know how to derive these things ideally. Not saying that we have to do it right away but I think the cleaner approach would be to pass a `WorkerResourceSpecFactory` to the `ActiveResourceManagerFactory` or even better, pass simply the default `WorkerResourceSpec` to the constructor of the `ActiveResourceManagerFactory`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services