tillrohrmann commented on a change in pull request #11320: [FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager at the worker granularity. URL: https://github.com/apache/flink/pull/11320#discussion_r403062228
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java ########## @@ -37,12 +37,12 @@ void releaseResource(InstanceID instanceId, Exception cause); /** - * Requests to allocate a resource with the given {@link ResourceProfile}. + * Requests to allocate a resource with the given {@link WorkerResourceSpec}. * - * @param resourceProfile for the to be allocated resource + * @param workerResourceSpec for the to be allocated worker Review comment: Usually `@param` requires a noun phrase: `@param workerResourceSpec workerResourceSpec specifies the size of the to be allocated resource`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services