KarmaGYZ commented on a change in pull request #14647: URL: https://github.com/apache/flink/pull/14647#discussion_r565769920
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedTaskManagerRegistration.java ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.instance.InstanceID; +import org.apache.flink.runtime.resourcemanager.registration.TaskExecutorConnection; +import org.apache.flink.util.Preconditions; + +import java.math.BigDecimal; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; + +/** + * A FineGrainedTaskManagerRegistration represents a TaskManager. It records the internal state of + * the TaskManager, including allocated/pending slots, total/available resources. + * + * <p>This class is the fine-grained resource management version of the {@link + * TaskManagerRegistration}. + */ +public class FineGrainedTaskManagerRegistration implements TaskManagerInfo { + private final TaskExecutorConnection taskManagerConnection; + + private final Map<AllocationID, FineGrainedTaskManagerSlot> slots; + + private final ResourceProfile defaultSlotResourceProfile; + + private final ResourceProfile totalResource; + + private final int defaultNumSlots; + + private ResourceProfile unusedResource; + + private ResourceProfile pendingResource = ResourceProfile.ZERO; + + /** Timestamp when the last time becoming idle. Otherwise Long.MAX_VALUE. */ + private long idleSince; + + public FineGrainedTaskManagerRegistration( + TaskExecutorConnection taskManagerConnection, + ResourceProfile totalResourceProfile, + ResourceProfile defaultSlotResourceProfile) { + this.taskManagerConnection = Preconditions.checkNotNull(taskManagerConnection); + this.totalResource = Preconditions.checkNotNull(totalResourceProfile); + this.defaultSlotResourceProfile = Preconditions.checkNotNull(defaultSlotResourceProfile); + + this.slots = new HashMap<>(16); + + this.defaultNumSlots = + totalResourceProfile + .getCpuCores() + .getValue() + .divide( + defaultSlotResourceProfile.getCpuCores().getValue(), + 0, + BigDecimal.ROUND_DOWN) + .intValue(); Review comment: Yes, I also agree that the number of registered/free slots might be invalid under fine-grained resource management. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
