KarmaGYZ commented on a change in pull request #14647: URL: https://github.com/apache/flink/pull/14647#discussion_r565846698
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceAllocationResult.java ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.instance.InstanceID; +import org.apache.flink.runtime.slots.ResourceCounter; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** Contains the results of the {@link ResourceAllocationStrategy}. */ +public class ResourceAllocationResult { + private final Set<JobID> unfulfillableJobs; + private final Map<JobID, Map<InstanceID, ResourceCounter>> registeredResourceAllocationResult; + private final List<PendingTaskManager> pendingTaskManagersToBeAllocated; + private final Map<PendingTaskManagerId, Map<JobID, ResourceCounter>> + pendingResourceAllocationResult; + + private ResourceAllocationResult( + Set<JobID> unfulfillableJobs, + Map<JobID, Map<InstanceID, ResourceCounter>> registeredResourceAllocationResult, + List<PendingTaskManager> pendingTaskManagersToBeAllocated, + Map<PendingTaskManagerId, Map<JobID, ResourceCounter>> + pendingResourceAllocationResult) { + this.unfulfillableJobs = unfulfillableJobs; + this.registeredResourceAllocationResult = registeredResourceAllocationResult; + this.pendingTaskManagersToBeAllocated = pendingTaskManagersToBeAllocated; + this.pendingResourceAllocationResult = pendingResourceAllocationResult; + } + + public List<PendingTaskManager> getPendingTaskManagersToBeAllocated() { + return Collections.unmodifiableList(pendingTaskManagersToBeAllocated); + } + + public Set<JobID> getUnfulfillableJobs() { + return Collections.unmodifiableSet(unfulfillableJobs); + } + + public Map<JobID, Map<InstanceID, ResourceCounter>> getRegisteredResourceAllocationResult() { + return Collections.unmodifiableMap(registeredResourceAllocationResult); Review comment: That's a good point. I agree that the strict unmodifiability is not necessary for this PR, given that it is more than 5000 lines now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
