KarmaGYZ commented on a change in pull request #14647: URL: https://github.com/apache/flink/pull/14647#discussion_r565849050
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java ########## @@ -0,0 +1,790 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.time.Time; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.clusterframework.types.SlotID; +import org.apache.flink.runtime.concurrent.FutureUtils; +import org.apache.flink.runtime.concurrent.ScheduledExecutor; +import org.apache.flink.runtime.instance.InstanceID; +import org.apache.flink.runtime.metrics.MetricNames; +import org.apache.flink.runtime.metrics.groups.SlotManagerMetricGroup; +import org.apache.flink.runtime.resourcemanager.ResourceManagerId; +import org.apache.flink.runtime.resourcemanager.WorkerResourceSpec; +import org.apache.flink.runtime.resourcemanager.registration.TaskExecutorConnection; +import org.apache.flink.runtime.slots.ResourceCounter; +import org.apache.flink.runtime.slots.ResourceRequirement; +import org.apache.flink.runtime.slots.ResourceRequirements; +import org.apache.flink.runtime.taskexecutor.SlotReport; +import org.apache.flink.util.FlinkException; +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.Executor; +import java.util.concurrent.ScheduledFuture; +import java.util.concurrent.TimeUnit; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** Implementation of {@link SlotManager} supporting fine-grained resource management. */ +public class FineGrainedSlotManager implements SlotManager { + private static final Logger LOG = LoggerFactory.getLogger(FineGrainedSlotManager.class); + + private final TaskManagerTracker taskManagerTracker; + private final ResourceTracker resourceTracker; + private final ResourceAllocationStrategy resourceAllocationStrategy; + + private final SlotStatusSyncer slotStatusSyncer; + + /** Scheduled executor for timeouts. */ + private final ScheduledExecutor scheduledExecutor; + + /** Timeout after which an unused TaskManager is released. */ + private final Time taskManagerTimeout; + + private final SlotManagerMetricGroup slotManagerMetricGroup; + + private final Map<JobID, String> jobMasterTargetAddresses = new HashMap<>(); + + /** Defines the max limitation of the total number of task executors. */ + private final int maxTaskManagerNum; + + /** Defines the number of redundant task executors. */ + private final int redundantTaskManagerNum; + + /** + * Release task executor only when each produced result partition is either consumed or failed. + */ + private final boolean waitResultConsumedBeforeRelease; + + /** The default resource spec of workers to request. */ + private final WorkerResourceSpec defaultWorkerResourceSpec; + + /** The resource profile of default slot. */ + private final ResourceProfile defaultSlotResourceProfile; + + private boolean sendNotEnoughResourceNotifications = true; + + /** ResourceManager's id. */ + @Nullable private ResourceManagerId resourceManagerId; + + /** Executor for future callbacks which have to be "synchronized". */ + @Nullable private Executor mainThreadExecutor; + + /** Callbacks for resource (de-)allocations. */ + @Nullable private ResourceActions resourceActions; + + private ScheduledFuture<?> taskManagerTimeoutsAndRedundancyCheck; + + /** True iff the component has been started. */ + private boolean started; + + public FineGrainedSlotManager( + ScheduledExecutor scheduledExecutor, + SlotManagerConfiguration slotManagerConfiguration, + SlotManagerMetricGroup slotManagerMetricGroup, + ResourceTracker resourceTracker, + TaskManagerTracker taskManagerTracker) { + + this.scheduledExecutor = Preconditions.checkNotNull(scheduledExecutor); + + Preconditions.checkNotNull(slotManagerConfiguration); + this.taskManagerTimeout = slotManagerConfiguration.getTaskManagerTimeout(); + this.redundantTaskManagerNum = slotManagerConfiguration.getRedundantTaskManagerNum(); + this.waitResultConsumedBeforeRelease = + slotManagerConfiguration.isWaitResultConsumedBeforeRelease(); + this.defaultWorkerResourceSpec = slotManagerConfiguration.getDefaultWorkerResourceSpec(); + this.resourceAllocationStrategy = slotManagerConfiguration.getResourceAllocationStrategy(); + int numSlotsPerWorker = slotManagerConfiguration.getNumSlotsPerWorker(); + this.maxTaskManagerNum = slotManagerConfiguration.getMaxSlotNum() / numSlotsPerWorker; Review comment: I create https://issues.apache.org/jira/browse/FLINK-21177 for it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
