KarmaGYZ commented on a change in pull request #14647: URL: https://github.com/apache/flink/pull/14647#discussion_r565806651
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncer.java ########## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.clusterframework.types.SlotID; +import org.apache.flink.runtime.concurrent.FutureUtils; +import org.apache.flink.runtime.instance.InstanceID; +import org.apache.flink.runtime.messages.Acknowledge; +import org.apache.flink.runtime.resourcemanager.ResourceManagerId; +import org.apache.flink.runtime.taskexecutor.SlotReport; +import org.apache.flink.runtime.taskexecutor.SlotStatus; +import org.apache.flink.runtime.taskexecutor.TaskExecutorGateway; +import org.apache.flink.runtime.taskexecutor.exceptions.SlotOccupiedException; +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.HashSet; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.Executor; + +/** Default implementation of {@link SlotStatusSyncer} for fine-grained slot management. */ +public class DefaultSlotStatusSyncer implements SlotStatusSyncer { + private static final Logger LOG = LoggerFactory.getLogger(DefaultSlotStatusSyncer.class); + + private final TaskManagerTracker taskManagerTracker; + private final ResourceTracker resourceTracker; + private final Set<AllocationID> pendingSlotAllocations; + /** Timeout for slot requests to the task manager. */ + private final Time taskManagerRequestTimeout; + + public DefaultSlotStatusSyncer( + TaskManagerTracker taskManagerTracker, + ResourceTracker resourceTracker, + Time taskManagerRequestTimeout) { + this.taskManagerTracker = Preconditions.checkNotNull(taskManagerTracker); + this.resourceTracker = Preconditions.checkNotNull(resourceTracker); + this.taskManagerRequestTimeout = Preconditions.checkNotNull(taskManagerRequestTimeout); + + this.pendingSlotAllocations = new HashSet<>(16); + } + + @Override + public CompletableFuture<Void> allocateSlot( + InstanceID instanceId, + JobID jobId, + String targetAddress, + ResourceProfile resourceProfile, + ResourceManagerId resourceManagerId, + Executor mainThreadExecutor) { + final AllocationID allocationId = new AllocationID(); + final Optional<TaskManagerInfo> taskManager = + taskManagerTracker.getRegisteredTaskManager(instanceId); + Preconditions.checkState( + taskManager.isPresent(), + "Could not find a registered task manager for instance id " + instanceId + '.'); + final TaskExecutorGateway gateway = + taskManager.get().getTaskExecutorConnection().getTaskExecutorGateway(); + + taskManagerTracker.notifySlotStatus( + allocationId, jobId, instanceId, resourceProfile, SlotState.PENDING); + resourceTracker.notifyAcquiredResource(jobId, resourceProfile); + pendingSlotAllocations.add(allocationId); + + // RPC call to the task manager + CompletableFuture<Acknowledge> requestFuture = + gateway.requestSlot( + SlotID.getDynamicSlotID( + taskManager.get().getTaskExecutorConnection().getResourceID()), + jobId, + allocationId, + resourceProfile, + targetAddress, + resourceManagerId, + taskManagerRequestTimeout); + + CompletableFuture<Void> returnedFuture = new CompletableFuture<>(); + + FutureUtils.assertNoException( + requestFuture.handleAsync( Review comment: We use `handleAsync` in case there is an exception during the handling of the `acknowledge` or `throwable` returned by the `requestFuture `. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
