[ 
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350730#comment-15350730
 ] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r68550807
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
    @@ -98,6 +98,12 @@ public void testRun() {
                                RunOptions options = 
CliFrontendParser.parseRunCommand(parameters);
                                assertEquals("expectedSavepointPath", 
options.getSavepointPath());
                        }
    +                   // test configure configDir
    +                   {
    +                           String[] parameters = {"-D", 
"expectedConfigDirectory", getTestJarPath()};
    --- End diff --
    
    Both long and short option should be tested (though I think we can remove 
the short option).


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable 
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if 
> it is started via the flink shell script. In order to improve the user 
> exprience, I would propose to introduce a {{--configDir}} parameter which the 
> user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to