[ 
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350731#comment-15350731
 ] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r68551023
  
    --- Diff: flink-dist/src/main/flink-bin/bin/flink ---
    @@ -17,6 +17,20 @@
     # limitations under the License.
     
################################################################################
     
    +function abspath() {
    +    if [ -d "$1" ]; then
    +        # dir
    +        (cd "$1"; pwd)
    +    elif [ -f "$1" ]; then
    +        # file
    +        if [[ $1 == */* ]]; then
    +            echo "$(cd "${1%/*}"; pwd)/${1##*/}"
    +        else
    +            echo "$(pwd)/$1"
    --- End diff --
    
    Have you looked in `config.sh`? There is a function for resolving symbolic 
links. What happens in case of cyclic symbolic links?


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable 
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if 
> it is started via the flink shell script. In order to improve the user 
> exprience, I would propose to introduce a {{--configDir}} parameter which the 
> user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to