[ 
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350732#comment-15350732
 ] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r68551210
  
    --- Diff: flink-dist/src/main/flink-bin/bin/flink ---
    @@ -33,6 +47,22 @@ while [ -L "$target" ]; do
         iteration=$((iteration + 1))
     done
     
    +
    +#Search --configDir into the parameters and set it as FLINK_CONF_DIR
    +args=("$@")
    +for i in "${!args[@]}"; do
    +    if [[ ${args[$i]} = "--configDir" || ${args[$i]} = "-D" ]]; then
    +        dir=${args[$(($i+1))]}
    +        if [ -d "$dir" ]; then
    +            FLINK_CONF_DIR= abspath ${dir}
    --- End diff --
    
    Should never assign to the variable because of the space after `=`.


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable 
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if 
> it is started via the flink shell script. In order to improve the user 
> exprience, I would propose to introduce a {{--configDir}} parameter which the 
> user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to