[jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners

[Renkai Ge (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419763#comment-15419763
 ] 

Renkai Ge commented on FLINK-4282:
----------------------------------

Thanks,[~aljoscha].It's a brilliant idea,but the result might be larger than 
timestamp if offset is too large,so I think we might to mod twice in this 
method.
{code:java}
        public static long getWindowStartWithOffset(long timestamp, long 
offset, long windowSize) {
                return timestamp - ((timestamp - offset) % windowSize + 
windowSize) % windowSize;
        }
{code}

> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days 
> are aligned with GMT. This is somewhat problematic for people living in 
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)