[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426424#comment-15426424
]
ASF GitHub Bot commented on FLINK-4282:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305729
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
---
@@ -102,7 +105,32 @@ public String toString() {
* @return The time policy.
*/
public static SlidingEventTimeWindows of(Time size, Time slide) {
- return new SlidingEventTimeWindows(size.toMilliseconds(),
slide.toMilliseconds());
+ return new SlidingEventTimeWindows(size.toMilliseconds(),
slide.toMilliseconds(),0);
+ }
+
+ /**
+ * Creates a new {@code SlidingEventTimeWindows} {@link
WindowAssigner} that assigns
+ * elements to time windows based on the element timestamp and offset.
+ *<p>
+ * For example, if you want window a stream by hour,but window
begins at the 15th minutes
+ * of each hour, you can use {@code
of(Time.hours(1),Time.minutes(15))},then you will get
--- End diff --
Missing space after comma.
> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
> Key: FLINK-4282
> URL: https://issues.apache.org/jira/browse/FLINK-4282
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days
> are aligned with GMT. This is somewhat problematic for people living in
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
