[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426422#comment-15426422
]
ASF GitHub Bot commented on FLINK-4282:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305677
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
---
@@ -52,16 +52,19 @@
private final long slide;
- protected SlidingEventTimeWindows(long size, long slide) {
+ private final long offset;
+
+ protected SlidingEventTimeWindows(long size, long slide,long offset) {
this.size = size;
this.slide = slide;
+ this.offset = offset;
}
@Override
public Collection<TimeWindow> assignWindows(Object element, long
timestamp, WindowAssignerContext context) {
if (timestamp > Long.MIN_VALUE) {
List<TimeWindow> windows = new ArrayList<>((int) (size
/ slide));
- long lastStart = timestamp - timestamp % slide;
+ long lastStart =
TimeWindow.getWindowStartWithOffset(timestamp,offset,slide);
--- End diff --
Missing spaces after comma.
> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
> Key: FLINK-4282
> URL: https://issues.apache.org/jira/browse/FLINK-4282
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days
> are aligned with GMT. This is somewhat problematic for people living in
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
