gyfora opened a new pull request, #724:
URL: https://github.com/apache/flink-kubernetes-operator/pull/724
## What is the purpose of the change
A common request is to support a streamlined, user friendly way of
redeploying from a target savepoint.
Previously this was only possible by deleting the CR and recreating it with
initialSavepointPath. A big downside of this approach is a loss of
savepoint/checkpoint history in the status that some platforms may need,
resulting in non-cleaned up save points etc.
We introduce a `savepointRedeployNonce` field in the job spec similar to
other action trigger nonces.
If the nonce changes to a new non null value the job will be redeployed from
the path specified in the initialSavepointPath (or empty state If the path is
empty)
As redeployment requires the deletion of HA metadata and previous checkpoint
info, rollbacks are not supported after redeployments (changing the nonce)
The PR also introduces an improvement to the restartNonce and
savepointRedeployNonce to ignore null changes (when the user nulls out the
nonce). This is more practical and inline with the behaviour of the
savepoint/checkpoint triggering logic
## Brief change log
- *Add savepointRedeployNonce to `spec.job`*
- *Implement redeployment logic*
- *Tests*
- *Doc updates* [TODO]
## Verifying this change
Unit tests and manual validation on local and remote envs.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
yes
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs [TODO]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
