mxm commented on code in PR #724:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418956894
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -306,6 +319,40 @@ protected void resubmitJob(FlinkResourceContext<CR> ctx,
boolean requireHaMetada
restoreJob(ctx, specToRecover, ctx.getObserveConfig(),
requireHaMetadata);
}
+ private void redeployWithSavepoint(
+ FlinkResourceContext<CR> ctx,
+ Configuration deployConfig,
+ CR resource,
+ STATUS status,
+ SPEC currentDeploySpec,
+ JobState desiredJobState)
+ throws Exception {
+ LOG.info("Redeploying from savepoint");
+ cancelJob(ctx, UpgradeMode.STATELESS);
Review Comment:
That seems fair if we document this so there are no unexpected surprises.
You are right that taking a savepoint wouldn't really make sense for most
scenarios where one would like to use this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
