gyfora commented on code in PR #724:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418846318
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java:
##########
@@ -28,7 +28,9 @@ public enum DiffType {
/** Scalable spec change. */
SCALE,
/** Upgradable spec change. */
- UPGRADE;
+ UPGRADE,
+ /** Full redeploy from new state. */
+ SAVEPOINT_REDEPLOY;
Review Comment:
This allows us to distinguish this more cleanly in a single place instead of
having to add some new logic to compare with the lastReconciled spec etc.
This is not really an upgrade in how it was understood before. It doesn't
use / preserve state and also does not respect he upgradeMode. Special casing
under UPGRADE would probably be more confusing to users and make it harder to
test implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
