1996fanrui commented on code in PR #724:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418224880


##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -125,6 +125,7 @@ This page serves as a full reference for FlinkDeployment 
custom resource definit
 | checkpointTriggerNonce | java.lang.Long | Nonce used to manually trigger 
checkpoint for the running job. In order to trigger a checkpoint, change the 
number to anything other than the current value. |
 | upgradeMode | org.apache.flink.kubernetes.operator.api.spec.UpgradeMode | 
Upgrade mode of the Flink job. |
 | allowNonRestoredState | java.lang.Boolean | Allow checkpoint state that 
cannot be mapped to any job vertex in tasks. |
+| savepointRedeployNonce | java.lang.Long | Nonce used to trigger a full 
redeployment of the job from the savepoint path specified in 
initialSavepointPath or from empty state if initialSavepointPath is null. 
Rollback is not possible after redeployment. |

Review Comment:
   Should we mention `In order to trigger a XXX, change the number to anything 
other than the current value.`?
   
   Other `Nonce` parameters have already mention it, or we can mention it 
before all parameters part(In a common place, and specific parameter doesn't 
need to do it.). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to