KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432482972
########## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ########## @@ -118,26 +129,47 @@ public DefaultDeclarativeSlotPool( this.totalResourceRequirements = ResourceCounter.empty(); this.fulfilledResourceRequirements = ResourceCounter.empty(); this.slotToRequirementProfileMappings = new HashMap<>(); + this.componentMainThreadExecutor = Preconditions.checkNotNull(componentMainThreadExecutor); + this.slotRequestMaxInterval = slotRequestMaxInterval; } @Override public void increaseResourceRequirementsBy(ResourceCounter increment) { - if (increment.isEmpty()) { + updateResourceRequirementsBy( + increment, + () -> totalResourceRequirements = totalResourceRequirements.add(increment)); Review Comment: I lean to this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org