RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1432351722
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##########
@@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(
.createSlotPoolService(
jid,
createDeclarativeSlotPoolFactory(
-
jobMasterConfiguration.getConfiguration()));
+
jobMasterConfiguration.getConfiguration()),
+ null,
Review Comment:
hi, @KarmaGYZ Thank you very much for your comment.
Did you mean that we didn't decide to pass the values of
`slotRequestMaxInterval` `slotBatchAllocatable` here based on the
configuration, but instead directly used hard coding to pass the values ?
If so (IIUC), The reason for not doing so:
- We want to change the parameter transfer logic uniformly when the default
scheduler fully supports balanced scheduling.
- The current hard coded default values will not break the original logical
semantics
Please correct me if i'm wrong.
Any suggestion is appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
