snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467385245
##########
.github/workflows/ci.yml:
##########
@@ -49,8 +50,18 @@ jobs:
-Plicense-check \
| tee ${{ env.MVN_BUILD_OUTPUT_FILE }}
+ mvn ${MVN_COMMON_OPTIONS} dependency:tree -Plicense-check | tee ${{
env.MVN_DEPENDENCY_PLUGIN_OUTPUT_FILE }}
+
- name: Check licensing
run: |
- mvn ${MVN_COMMON_OPTIONS} exec:java@check-licensing -N \
Review Comment:
yep, i was thinking about that however had some doubts...
Since you've also mentioned this I think we should do that
##########
.github/workflows/ci.yml:
##########
@@ -49,8 +50,18 @@ jobs:
-Plicense-check \
| tee ${{ env.MVN_BUILD_OUTPUT_FILE }}
+ mvn ${MVN_COMMON_OPTIONS} dependency:tree -Plicense-check | tee ${{
env.MVN_DEPENDENCY_PLUGIN_OUTPUT_FILE }}
+
- name: Check licensing
run: |
- mvn ${MVN_COMMON_OPTIONS} exec:java@check-licensing -N \
Review Comment:
extracted into a separate commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
