snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467507163
##########
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml:
##########
@@ -128,6 +131,7 @@ under the License.
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>${zookeeper.version}</version>
+ <optional>${flink.markBundledAsOptional}</optional>
</dependency>
<dependency>
<groupId>io.netty</groupId>
Review Comment:
That's not about BOMs
in general it does not make sense to add it for depedencies inside
dependencyManagement
I removed it for others in dependencyManagement, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
