snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467762581
##########
.github/workflows/ci.yml:
##########
@@ -51,6 +52,14 @@ jobs:
- name: Check licensing
run: |
- mvn ${MVN_COMMON_OPTIONS} exec:java@check-licensing -N \
+ mvn ${MVN_COMMON_OPTIONS} exec:java@check-license -N \
-Dexec.args="${{ env.MVN_BUILD_OUTPUT_FILE }} $(pwd) ${{
env.MVN_VALIDATION_DIR }}" \
- -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties
\ No newline at end of file
+ -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties
+
+ - name: Check shade optional dependencies
+ run: |
+ mvn ${MVN_COMMON_OPTIONS} dependency:tree -Plicense-check | tee
${{ env.MVN_DEPENDENCY_PLUGIN_OUTPUT_FILE }}
Review Comment:
may be we need to rename the profile itself... :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
