snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467672006
##########
pom.xml:
##########
@@ -341,21 +342,41 @@ under the License.
<goals>
<goal>java</goal>
</goals>
+
+ <configuration>
+
<mainClass>org.apache.flink.tools.ci.licensecheck.LicenseChecker</mainClass>
+ </configuration>
+ </execution>
+ <execution>
+ <id>check-shade</id>
+ <!-- manually called -->
+ <phase>none</phase>
+ <goals>
+ <goal>java</goal>
+ </goals>
+
+ <configuration>
+
<mainClass>org.apache.flink.tools.ci.optional.ShadeOptionalChecker</mainClass>
+ </configuration>
</execution>
</executions>
<configuration>
-
<mainClass>org.apache.flink.tools.ci.licensecheck.LicenseChecker</mainClass>
<includePluginDependencies>true</includePluginDependencies>
<includeProjectDependencies>false</includeProjectDependencies>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-ci-tools</artifactId>
- <version>1.17-SNAPSHOT</version>
+ <version>1.18-SNAPSHOT</version>
Review Comment:
I think so.
I guess it could also go with its own hotfix commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
