snuyanzin commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1894978008
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ void testUsingAddJarWithCheckpointing() throws Exception {
+ env().enableCheckpointing(100);
+ tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+ ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
+ testUserDefinedFunctionByUsingJar(
+ env ->
+ env.executeSql(
+ String.format(
+ "create function lowerUdf as '%s'
LANGUAGE JAVA",
+ udfClassName)),
+ "drop function lowerUdf");
+
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+ }
Review Comment:
What does exactly this test check?
I'm asking since I executed it separately without changes in
`TableEnvironmentImpl`, `StreamTableEnvironment` and it is green.
Thus no need for any other change to make it happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
