snuyanzin commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1895004029


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
                 "drop function lowerUdf");
     }
 
+    @Test
+    void testUsingAddJarWithCheckpointing() throws Exception {
+        env().enableCheckpointing(100);
+        tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+        ClassLoader contextClassLoader = 
Thread.currentThread().getContextClassLoader();
+        testUserDefinedFunctionByUsingJar(
+                env ->
+                        env.executeSql(
+                                String.format(
+                                        "create function lowerUdf as '%s' 
LANGUAGE JAVA",
+                                        udfClassName)),
+                "drop function lowerUdf");
+        
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+    }

Review Comment:
   yep, I was checking in 2.0/master
   
   thanks for clarifying this.
   
   Then The question would be why are we creating something new here instead of 
backporting existing solution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to