davidradl commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2007397305
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -294,15 +290,20 @@ public PekkoRpcServiceBuilder withCustomConfig(final
Config customConfig) {
@Override
public PekkoRpcServiceBuilder withBindAddress(final String
bindAddress) {
- this.bindAddress = Preconditions.checkNotNull(bindAddress);
+ if (bindAddress != null) {
Review Comment:
why change you changed this - prior to the change we would get a null
pointer for null so we would end up in error processing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
