beliefer commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2008783221
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -294,15 +290,20 @@ public PekkoRpcServiceBuilder withCustomConfig(final
Config customConfig) {
@Override
public PekkoRpcServiceBuilder withBindAddress(final String
bindAddress) {
- this.bindAddress = Preconditions.checkNotNull(bindAddress);
+ if (bindAddress != null) {
Review Comment:
Yes. we must provide the bindAddress for `ActorSystem`.
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -294,15 +290,20 @@ public PekkoRpcServiceBuilder withCustomConfig(final
Config customConfig) {
@Override
public PekkoRpcServiceBuilder withBindAddress(final String
bindAddress) {
- this.bindAddress = Preconditions.checkNotNull(bindAddress);
+ if (bindAddress != null) {
Review Comment:
Yes. we must provide the `bindAddress` for `ActorSystem`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
