beliefer commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2008784238
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java:
##########
@@ -147,15 +147,11 @@ public static RpcService createRemoteRpcService(
@Nullable String bindAddress,
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
Optional<Integer> bindPort)
throws Exception {
- RpcSystem.RpcServiceBuilder rpcServiceBuilder =
- rpcSystem.remoteServiceBuilder(configuration, externalAddress,
externalPortRange);
- if (bindAddress != null) {
- rpcServiceBuilder = rpcServiceBuilder.withBindAddress(bindAddress);
Review Comment:
Before the change, `rpcServiceBuilder` do not set the `bindAddress`. After
the change, it is the same as.
`if (bindAddress != null) {` is moved from caller side to the inner of
`withBindAddress`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
