davidradl commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2007401000
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -78,13 +78,9 @@ static PekkoRpcService createRemoteRpcService(
throws Exception {
final PekkoRpcServiceBuilder rpcServiceBuilder =
PekkoRpcServiceUtils.remoteServiceBuilder(
- configuration, externalAddress, externalPortRange);
-
- if (bindAddress != null) {
- rpcServiceBuilder.withBindAddress(bindAddress);
- }
-
- bindPort.ifPresent(rpcServiceBuilder::withBindPort);
+ configuration, externalAddress,
externalPortRange)
Review Comment:
this changes behaviour - prior to the fix if there was no bindPort we would
build with the bind address if there was one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
