RocMarshal commented on code in PR #180: URL: https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2593250851
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/JdbcSqlSplitEnumeratorBase.java: ########## @@ -1,104 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.connector.jdbc.core.datastream.source.enumerator; - -import org.apache.flink.annotation.PublicEvolving; -import org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit; - -import javax.annotation.Nonnull; -import javax.annotation.Nullable; - -import java.io.IOException; -import java.io.Serializable; -import java.util.List; -import java.util.function.Supplier; - -/** - * Base class for jdbc sql split enumerator. - * - * @param <SplitT> JDBC split type. - */ -@PublicEvolving -public abstract class JdbcSqlSplitEnumeratorBase<SplitT> implements AutoCloseable, Serializable { Review Comment: I have rechecked the reason why this annotation was added at the time: - A：The `org.apache.flink.connector.jdbc.core.datastream.source.JdbcSource` is annotated as `@PublicEvolving` - But the constructor methed of `JdbcSource` visible scope is default without `public` keyword, although It's a bit odd. - B：Therefore, not only the classes directly exposed in JdbcBuilder, but also the classes exposed in the constructors of the Jdbc class should be annotated as `PublicEvolving`, that is, `JdbcSqlSplitEnumeratorBase` is annotated with `PublicEvolving` is correct. > Since this is a public API, we cannot throw it away like this, we need to deprecate it first and keep the related config methods (deprecated) as well. Therefore, overall, this suggestion requires our careful consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
