RocMarshal commented on code in PR #180: URL: https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2672790589
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/splitter/JdbcSqlSplitterEnumerator.java: ########## @@ -0,0 +1,71 @@ +package org.apache.flink.connector.jdbc.core.datastream.source.enumerator.splitter; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.jdbc.core.datastream.source.enumerator.JdbcSqlSplitEnumeratorBase; +import org.apache.flink.connector.jdbc.core.datastream.source.enumerator.SqlTemplateSplitEnumerator; +import org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit; +import org.apache.flink.connector.jdbc.datasource.connections.JdbcConnectionProvider; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +/** A split enumerator for JdbcSqlSplitEnumeratorBase. */ +@Deprecated Review Comment: If we could add explanations for every row marked as deprecated, that would be great—for example, some standard notes explaining which new API should be used as a replacement, and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
