RocMarshal commented on code in PR #180:
URL:
https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2676401726
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSource.java:
##########
@@ -71,12 +72,13 @@ public class JdbcSource<OUT>
private final @Nullable ContinuousUnBoundingSettings
continuousUnBoundingSettings;
private final Configuration configuration;
- private final JdbcSqlSplitEnumeratorBase.Provider<JdbcSourceSplit>
sqlSplitEnumeratorProvider;
+ private final SplitterEnumerator splitterEnumerator;
protected JdbcConnectionProvider connectionProvider;
private final ResultExtractor<OUT> resultExtractor;
private final DeliveryGuarantee deliveryGuarantee;
+ @Deprecated
Review Comment:
ditto
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/SqlTemplateSplitEnumerator.java:
##########
@@ -38,6 +38,7 @@
import java.util.function.Supplier;
/** A split enumerator based on sql-parameters grains. */
+@Deprecated
Review Comment:
ditto
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSourceBuilder.java:
##########
@@ -132,6 +135,12 @@ public class JdbcSourceBuilder<OUT> {
this.autoCommit = true;
}
+ public JdbcSourceBuilder<OUT> setSplitter(SplitterEnumerator
splitterEnumerator) {
+ this.splitterEnumerator = splitterEnumerator;
+ return this;
+ }
+
+ @Deprecated
Review Comment:
ditto
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/JdbcSqlSplitEnumeratorBase.java:
##########
@@ -34,6 +34,7 @@
*
* @param <SplitT> JDBC split type.
*/
+@Deprecated
Review Comment:
ditto missing the comments to describe the migration of the API
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/split/CompositeJdbcParameterValuesProvider.java:
##########
@@ -24,6 +24,7 @@
import java.io.Serializable;
/** Combine 2 {@link JdbcParameterValuesProvider} into 1. */
+@Deprecated
@Internal
public class CompositeJdbcParameterValuesProvider implements
JdbcParameterValuesProvider {
Review Comment:
ditto
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSourceBuilder.java:
##########
@@ -197,6 +206,7 @@ public JdbcSourceBuilder<OUT>
setContinuousUnBoundingSettings(
* If the value was set as an instance of {@link
JdbcSlideTimingParameterProvider}, it's
* required to specify the {@link #continuousUnBoundingSettings}.
*/
+ @Deprecated
public JdbcSourceBuilder<OUT> setJdbcParameterValuesProvider(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
