eskabetxe commented on code in PR #180:
URL:
https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2675469689
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSource.java:
##########
@@ -167,8 +189,8 @@ public static <OUT> JdbcSourceBuilder<OUT> builder() {
// ---- Visible for testing methods. ---
@VisibleForTesting
- public JdbcSqlSplitEnumeratorBase.Provider<JdbcSourceSplit>
getSqlSplitEnumeratorProvider() {
Review Comment:
We change the JdbcSource to have a SplitterEnumerator instead a
JdbcSqlSplitEnumeratorBase..
I can keep the method only if I can start returning null, and only returning
something when SplitterEnumerator is a instance of JdbcSqlSplitterEnumerator
(the class I create to allow the retrofit)
Being "@VisibleForTesting" is not already a warning that this method should
not be used?
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/splitter/JdbcSqlSplitterEnumerator.java:
##########
@@ -0,0 +1,71 @@
+package
org.apache.flink.connector.jdbc.core.datastream.source.enumerator.splitter;
+
+import org.apache.flink.annotation.Internal;
+import
org.apache.flink.connector.jdbc.core.datastream.source.enumerator.JdbcSqlSplitEnumeratorBase;
+import
org.apache.flink.connector.jdbc.core.datastream.source.enumerator.SqlTemplateSplitEnumerator;
+import
org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit;
+import
org.apache.flink.connector.jdbc.datasource.connections.JdbcConnectionProvider;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+/** A split enumerator for JdbcSqlSplitEnumeratorBase. */
+@Deprecated
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
