eskabetxe commented on code in PR #180:
URL:
https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r2676484894
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSource.java:
##########
@@ -71,12 +72,13 @@ public class JdbcSource<OUT>
private final @Nullable ContinuousUnBoundingSettings
continuousUnBoundingSettings;
private final Configuration configuration;
- private final JdbcSqlSplitEnumeratorBase.Provider<JdbcSourceSplit>
sqlSplitEnumeratorProvider;
+ private final SplitterEnumerator splitterEnumerator;
protected JdbcConnectionProvider connectionProvider;
private final ResultExtractor<OUT> resultExtractor;
private final DeliveryGuarantee deliveryGuarantee;
+ @Deprecated
Review Comment:
is a constructor calling the another constructor.
its self explained ..
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/SqlTemplateSplitEnumerator.java:
##########
@@ -38,6 +38,7 @@
import java.util.function.Supplier;
/** A split enumerator based on sql-parameters grains. */
+@Deprecated
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
