davidradl commented on code in PR #34:
URL:
https://github.com/apache/flink-connector-http/pull/34#discussion_r3115914670
##########
flink-connector-http/src/test/java/org/apache/flink/connector/http/sink/httpclient/JavaNetSinkHttpClientTest.java:
##########
@@ -134,5 +139,50 @@ public void
shouldBuildClientWithHeaders(RequestSubmitterFactory requestSubmitte
"Cache-Control",
"no-cache, no-store, max-age=0, must-revalidate");
assertPropertyArray(headersAndValues, "Access-Control-Allow-Origin",
"*");
+ // Default User-Agent header should also be present
+ assertPropertyArray(headersAndValues, "User-Agent",
"flink-http-connector");
Review Comment:
it looks like from the code that if a user agent header was added in the
headers part then that would take precedence over the explicit user agent
setting. Is this what we want? I suggest a config error if we have a clash like
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
