featzhang commented on PR #34:
URL:
https://github.com/apache/flink-connector-http/pull/34#issuecomment-4293180648
Hi @davidradl,
Thank you for the detailed review! I've addressed all your feedback:
## Changes Made:
1. **Default User-Agent Value**: Changed from `flink-http-connector` to
`flink-connector-http` as you suggested
- Updated in both sink and lookup configuration options
- Updated in documentation (English and Chinese)
- Updated in all test cases
2. **Header Conflict Validation**: Added validation to detect when
User-Agent is set both explicitly via `http.user.agent` config and in the
headers configuration
- Added conflict check in `JavaNetSinkHttpClient`
- Added conflict check in `RequestFactoryBase`
- Throws `IllegalArgumentException` with clear message when conflict is
detected
- Added test cases for both sink and lookup to verify the conflict
detection
The changes ensure that:
- Users get a clear error if they accidentally set User-Agent in two places
- The default value follows Apache Flink naming conventions
- All existing functionality is preserved
Please let me know if there's anything else that needs to be addressed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
