featzhang commented on PR #34: URL: https://github.com/apache/flink-connector-http/pull/34#issuecomment-4367910297
Hi @davidradl, friendly ping — all three of your review threads on this PR are now marked as resolved and the latest commit (`31fc409`) addresses each of them: | Thread | Fix | |--------|-----| | `JavaNetSinkHttpClient.java` L76 — *"why a dedicated config, prefix headers already work"* | Kept the dedicated `ConfigOption` so there is a named, documented entry point and a sensible default (requests no longer go out with no `User-Agent` at all). | | `HttpDynamicSinkConnectorOptions.java` L51 — *"default to `flink-connector-http`"* | Default changed to `flink-connector-http` on both sink and lookup sides. | | `JavaNetSinkHttpClientTest.java` L143 — *"config error on User-Agent clash"* | Setting User-Agent via both `http.user.agent` and `http.(sink|source.lookup).header.User-Agent` now throws `IllegalArgumentException` at factory creation with a clear message; covered by new unit tests on both sink and lookup clients. | Plus: documentation rows + a `User-Agent` subsection added in `docs/content` and `docs/content.zh`, Java 17 compile fix, rebased on current `main` (`813fd5d`). CI (GitHub Actions Java 11 + 17) is green. PR is `MERGEABLE`. Would you mind taking another look when you have a moment? Happy to iterate further if anything still looks off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
