davidradl commented on code in PR #34:
URL:
https://github.com/apache/flink-connector-http/pull/34#discussion_r3187869363
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -208,6 +209,7 @@ Note the options with the prefix _http_ are the HTTP
connector specific options,
| http.request.query-param-fields-with-key |
optional | A map of column names to query parameter keys. See the [Query
Parameter Mapping](#query-parameter-mapping) section for details and examples.
|
| http.request.body-template |
optional | Used for the `http-generic-json-url` query creator. A JSON template
string for constructing the request body for PUT and POST operations. Use
`{{fieldName}}` placeholders to reference top-level columns from the lookup
table. Supports creating complex nested JSON structures with both placeholders
and literal values. See the [Body Template](#body-template) section for details
and examples.
|
| http.request.url-map |
optional | Used for the `http-generic-json-url` query creator. The map of
insert names to column names used as url segments. Parses a string as a map of
strings. For example if there are table columns called `customerId` and
`orderId`, then specifying value `customerId:cid,orderID:oid` and a url of
https://myendpoint/customers/{cid}/orders/{oid} will mean that the url used for
the lookup query will dynamically pickup the values for `customerId`, `orderId`
and use them in the url e.g. https://myendpoint/customers/cid1/orders/oid1. The
expected format of the map is: `key1:value1,key2:value2`. |
+| http.user.agent |
optional | The value of the `User-Agent` HTTP header sent with every lookup
request. Defaults to `flink-connector-http`. Setting this option together with
`http.source.lookup.header.User-Agent` is not allowed and will fail with a
configuration error.
|
Review Comment:
I think we should put the new option near the top around url, so we start
with all the common configuration options then specialize to the sink or lookup
appropriately when we list them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
