gyfora commented on code in PR #1101:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1101#discussion_r3145104498
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -370,9 +370,12 @@ public CancelResult cancelSessionJob(
switch (suspendMode) {
case STATELESS:
case CANCEL:
- cancelJobOrError(clusterClient, status, suspendMode ==
SuspendMode.STATELESS);
- // This is async we need to return and re-observe
- return CancelResult.pending();
+ if (cancelJobOrError(
Review Comment:
I think this is a very nice improvement, we can and should of course fix the
FlinkDeployment path as well. I can update the jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
