prshnt commented on code in PR #1101:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1101#discussion_r3152294469
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -383,14 +388,14 @@ public CancelResult cancelSessionJob(
return CancelResult.completed(savepointPath);
}
- public void cancelJobOrError(
+ public boolean cancelJobOrError(
Review Comment:
Yep, looking at it again does make sense I will swap the values and also
have the javadoc ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
