Dennis-Mircea commented on code in PR #1101:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1101#discussion_r3153054243
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -345,9 +345,11 @@ protected CancelResult cancelJob(
}
break;
case CANCEL:
- cancelJobOrError(clusterClient, status, false);
- // This is async we need to return
- return CancelResult.pending();
+ if (!cancelJobOrError(clusterClient, status, false)) {
Review Comment:
Don't we need here to have the same check as for session jobs: `suspendMode
== SuspendMode.STATELESS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
