gyfora commented on code in PR #1101:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1101#discussion_r3152085956
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -383,14 +388,14 @@ public CancelResult cancelSessionJob(
return CancelResult.completed(savepointPath);
}
- public void cancelJobOrError(
+ public boolean cancelJobOrError(
Review Comment:
Can we please add some javadocs here explaining the return param? Also I
find it a bit strange to return true if the cancellation is pending and false
if it is already done. Maybe we could swap the boolean values, I leave this up
to you, as long as it's documented in the javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
