gaborgsomogyi opened a new pull request, #28070:
URL: https://github.com/apache/flink/pull/28070
## What is the purpose of the change
`s3.sse.kms.encryption-context` was listed in the README as a supported
configuration option for SSE-KMS, but the corresponding ConfigOption never
existed in NativeS3FileSystemFactory. As a result, the encryption context was
silently ignored regardless of what users configured, and the `sseKms(keyId,
context)` code path in `S3EncryptionConfig` was dead code unreachable from
production.
This PR closes the gap by adding the missing config option and wiring it
end-to-end.
## Brief change log
- Fix: Add `SSE_KMS_ENCRYPTION_CONTEXT` (`s3.sse.kms.encryption-context`)
ConfigOption to `NativeS3FileSystemFactory` and wire it through
`S3EncryptionConfig.fromConfig()` — the feature was documented but never
implemented
- Fix: Update docs (README, s3.md EN/ZH) with correct aws:s3:arn encryption
context example reflecting real AWS usage
- Tests: Add unit tests for `S3EncryptionConfig`, `S3ExceptionUtils`,
`S3FileStatus`, `S3BlockLocation`
## Verifying this change
Existing and new unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? docs
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
