gaborgsomogyi commented on code in PR #28070:
URL: https://github.com/apache/flink/pull/28070#discussion_r3167829307
##########
docs/content.zh/docs/deployment/filesystems/s3.md:
##########
@@ -173,7 +173,8 @@ In addition to the [common
configuration](#common-configuration) options (`s3.ac
```yaml
# Server-side encryption
s3.sse.type: sse-s3 # or sse-kms, aws:kms, AES256, none (default)
-s3.sse.kms.key-id: arn:aws:kms:region:account:key/id # Required for SSE-KMS
+s3.sse.kms.key-id: arn:aws:kms:region:account:key/id # Optional: custom KMS
key for SSE-KMS
+s3.sse.kms.encryption-context: {"aws:s3:arn":
"arn:aws:s3:::my-bucket/my-file"} # Optional: KMS encryption context
Review Comment:
Since Flink 2.0, `flink-conf.yaml` is dropped and only `config.yaml`
(standard YAML 1.2) is supported. The `{"aws:s3:arn":
"arn:aws:s3:::my-bucket/my-file"}` notation is a YAML flow mapping, which is
valid YAML 1.2. `convertToProperties` handles it correctly: the YAML file
reader either delivers it directly as a `Map` (hits the `instanceof Map`
branch) or `YamlParserUtils.convertToObject` parses it from the string
representation. The `key:value,key:value` concern only applies to the old
`flink-conf.yaml` legacy parser, which is no longer relevant. The current
example is correct for `config.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
