gaborgsomogyi commented on code in PR #28070:
URL: https://github.com/apache/flink/pull/28070#discussion_r3167832268
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3EncryptionConfig.java:
##########
@@ -163,7 +162,9 @@ public static S3EncryptionConfig fromConfig(
return sseS3();
case "SSE_KMS":
case "AWS_KMS":
- return kmsKeyId != null && !kmsKeyId.isEmpty() ?
sseKms(kmsKeyId) : sseKms();
Review Comment:
Good catch. The `SSE_KMS` case exists only because
`toUpperCase().replace("-","_")` collapses both `sse-kms` and the literal
`SSE_KMS` into the same string. Switching to `toLowerCase(Locale.ROOT)` and
matching the actual input forms (`sse-kms`, `aws:kms`, `aes256`) lets us drop
the artificial intermediate form entirely - `SSE_KMS` as a literal input simply
stops resolving. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
