gaborgsomogyi commented on code in PR #28070:
URL: https://github.com/apache/flink/pull/28070#discussion_r3172585785
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3ClientProvider.java:
##########
@@ -135,6 +135,7 @@ public S3EncryptionConfig getEncryptionConfig() {
}
@VisibleForTesting
+ @Nullable
Review Comment:
This alone is not enough because there are nullable marker scattered around
and we should make that consistent... We need to check if we remove all then
what will happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
