Samrat002 commented on code in PR #6:
URL: 
https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178627912


##########
flink-connector-redis-streams/src/main/resources/META-INF/NOTICE:
##########
@@ -0,0 +1,24 @@
+flink-connector-redis-streams
+Copyright 2014-2026 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- io.lettuce:lettuce-core:7.5.0.RELEASE
+- io.netty:netty-common:4.1.115.Final
+- io.netty:netty-handler:4.1.115.Final
+- io.netty:netty-transport:4.1.115.Final
+- io.netty:netty-codec:4.1.115.Final
+- io.netty:netty-buffer:4.1.115.Final
+- io.netty:netty-resolver:4.1.115.Final
+- io.netty:netty-transport-native-unix-common:4.1.115.Final
+- org.apache.flink:flink-connector-base:2.2.0
+- org.apache.flink:flink-core:2.2.0
+- org.apache.flink:flink-streaming-java:2.2.0
+
+This project bundles the following dependencies under the MIT License 
(https://opensource.org/licenses/MIT)
+
+- org.reactivestreams:reactive-streams:1.0.4
+- org.slf4j:slf4j-api:1.7.36

Review Comment:
   slf4j-api is declared as a provided scope in pom.xml — it is not packaged in 
the connector artifact. Apache policy requires NOTICE attribution only for 
dependencies that are bundled. Provided-scope dependencies are supplied by the 
runtime and are not our responsibility to list.    
   The current NOTICE correctly omits slf4j-api. If there is a specific ASF 
legal guideline you are pointing to, please share it, and I will comply 
immediately. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to