Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178630929
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplit.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.SourceSplit; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.Objects; + +/** + * Immutable Redis Stream split: identity is {@link #streamKey}; {@link #startingEntryId} is an + * informational resume position (canonical state lives in the Redis consumer group); + * {@link #stoppingEntryId} is non-null only in bounded mode. + */ +@Internal +public class RedisStreamsSourceSplit implements SourceSplit { + + private final String streamKey; + @Nullable private final String startingEntryId; Review Comment: startingEntryId is not dead. It serves two active purposes: 1. State initialisation. RedisStreamsSourceSplitState copies it into currentEntryId in its constructor (this.currentEntryId = split.getStartingEntryId()). After the emitter processes records, setCurrentEntryId advances this value, and toSplit() snapshots it back into a new RedisStreamsSourceSplit. This is how the advancing read position survives checkpoints and Flink task rebalancing. 2. Observability. The stored position lets operators inspect the last committed offset in a checkpoint dump without querying Redis. The field deliberately does not drive actual XREADGROUP positioning. It is delegated to the Redis server-side consumer-group state. This design choice is documented in the class Javadoc to prevent confusion. The field is load-bearing, just not at the network layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
