spuru9 commented on PR #1170:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1170#issuecomment-5195309310
The migration only covers the operator module. operator-api and standalone
pick up slf4j-api 1.7.36 transitively from Flink (flink-annotations and
flink-kubernetes), but I've switched them to the 2.x binding, so both now run
on a NOP logger with all output silently discarded. No error, nothing in the
test output. operator-api is published, so downstream consumers who don't pin
slf4j would inherit it too.
Pinning slf4j-api to fix that has a knock-on: autoscaler and plugin-jdbc
have no binding of their own beyond the log4j-slf4j-impl 2.24.3 that
flink-test-utils-junit drags in, so they'd go NOP as well. The operator module
pulls the same old binding through flink-test-utils (no -junit).
Two options:
1. Global pin — what I've already got working. slf4j-api in root
dependencyManagement, plus excluding the old binding from flink-test-utils /
-junit in three modules and adding the 2.x binding at test scope in two.
2. Update the required dependency in 1.20.x and then use those after the
next release - that could be a major bump for a 1.x flink which we don't alter
much and is just maintained.
What is you suggestion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
