spuru9 commented on code in PR #1170:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1170#discussion_r3731635088
##########
flink-kubernetes-operator/pom.xml:
##########
@@ -164,6 +165,13 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-core</artifactId>
Review Comment:
Redundant — removed, good catch.
`logback-classic` declares `logback-core` at compile scope, so it still
resolves as `ch.qos.logback:logback-core:jar:1.5.34:provided` without the
explicit declaration, and the `artifactItem` that stages it into the image pins
`${logback.version}` itself. So the declaration was feeding neither the
classpath nor the image.
I kept `logback-core` in the block comment above, since it is still shipped
as a separate JAR and still excluded from the shaded JAR — happy to drop that
mention too if you would rather the comment only name the direct dependencies.
##########
docs/content.zh/docs/operations/logging.md:
##########
@@ -115,10 +115,10 @@ Logback XML overrides replace the entire default
configuration. Unlike Log4j2 `.
## Logging Library Version Overrides
-The operator ships with Logback 1.2.x and SLF4J 1.7.x. These versions are
bundled in the Docker image and the SLF4J 1.7.x API is shaded into the operator
JAR.
+The operator ships with Logback 1.5.x and SLF4J 2.0.x. These versions are
bundled in the Docker image and the SLF4J 2.0.x API is shaded into the operator
JAR.
{{< hint warning >}}
-Upgrading to Logback 1.4+/1.5+ or SLF4J 2.x is not supported. SLF4J 2.x uses a
`ServiceLoader`-based binding mechanism that is incompatible with the SLF4J
1.7.x API shaded inside the operator. Replacing the JARs at runtime will result
in `ClassNotFoundException: org.slf4j.impl.StaticLoggerBinder`.
+Downgrading to Logback 1.2.x or SLF4J 1.7.x is not supported. SLF4J 2.x
locates the backend through a `ServiceLoader`
(`org.slf4j.spi.SLF4JServiceProvider`), whereas Logback 1.2.x provides the
older `org.slf4j.impl.StaticLoggerBinder`, which SLF4J 2.x ignores. Replacing
the JARs at runtime does not raise an error: SLF4J falls back to a no-operation
logger and all log output is silently discarded.
{{< /hint >}}
Review Comment:
Agreed — removed, from both the English and the zh copy (the hint was
identical in each).
That leaves `## Logging Library Version Overrides` as a single sentence
stating which versions the operator ships. A heading about overrides with no
override content reads a little odd to me, so say the word if you would rather
the whole section go and I will drop it in the same commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
