spuru9 commented on code in PR #1170:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1170#discussion_r3731635088
##########
flink-kubernetes-operator/pom.xml:
##########
@@ -164,6 +165,13 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-core</artifactId>
Review Comment:
Redundant — removed, good catch.
`logback-classic` declares `logback-core` at compile scope, so it still
resolves as `ch.qos.logback:logback-core:jar:1.5.34:provided` without the
explicit declaration, and the `artifactItem` that stages it into the image pins
`${logback.version}` itself. So the declaration was feeding neither the
classpath nor the image.
I kept `logback-core` in the block comment above, since it is still shipped
as a separate JAR and still excluded from the shaded JAR — happy to drop that
mention too if you would rather the comment only name the direct dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
